Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Be more specific matching an expected-failure #4618

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

phil-davis
Copy link
Contributor

Description

Be more specific in matching the format [someSuite/someFeature.feature:42] of an expected-failure.

Do not assume that it is preceded by a - and a single space. Codacy in owncloud/ocis complains a lot about .md file format and insists on particular spacing. So we do not want to depend on the exact spacing of this sort of thing.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis added Status:Needs-Review Needs review from a maintainer QA:team labels Jan 15, 2021
@phil-davis phil-davis self-assigned this Jan 15, 2021
Copy link
Contributor

@haribhandari07 haribhandari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis added Status:Needs-release and removed Status:Needs-Review Needs review from a maintainer labels Jan 15, 2021
@phil-davis phil-davis merged commit c2acb0a into master Jan 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the adjust-match-for-expected-failures branch January 15, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants